Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 799073005: Write the packaged USB gadget app in binary mode. (Closed)

Created:
6 years ago by Reilly Grant (use Gerrit)
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Write the packaged USB gadget app in binary mode. On Windows binary files will be corrupted if they are not written in binary mode. BUG= Committed: https://crrev.com/4d1bd58166ba82a9751ad8c66ccce6764922a14a Cr-Commit-Position: refs/heads/master@{#308377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/usb_gadget/package.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Hey Ken, this is an easy one.
6 years ago (2014-12-13 00:40:58 UTC) #2
Ken Rockot(use gerrit already)
On 2014/12/13 00:40:58, reillyg wrote: > Hey Ken, this is an easy one. lgtm
6 years ago (2014-12-15 17:33:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799073005/1
6 years ago (2014-12-15 17:50:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 18:50:55 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 18:51:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d1bd58166ba82a9751ad8c66ccce6764922a14a
Cr-Commit-Position: refs/heads/master@{#308377}

Powered by Google App Engine
This is Rietveld 408576698