Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 799073004: Remove dead code from StyleSheetContents and CSSStyleSheet. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
ojan, eseidel
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove dead code from StyleSheetContents and CSSStyleSheet. This code was for external stylesheets which we don't support. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/88e538a78b8b8947183ab626492bd670de6ea090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -86 lines) Patch
M sky/engine/core/css/CSSStyleSheet.h View 2 chunks +3 lines, -22 lines 0 comments Download
M sky/engine/core/css/CSSStyleSheet.cpp View 2 chunks +6 lines, -22 lines 0 comments Download
M sky/engine/core/css/CSSTestHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/StyleSheetContents.h View 5 chunks +2 lines, -17 lines 0 comments Download
M sky/engine/core/css/StyleSheetContents.cpp View 3 chunks +1 line, -20 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years ago (2014-12-13 00:09:27 UTC) #2
ojan
lgtm
6 years ago (2014-12-13 00:20:47 UTC) #3
esprehn
6 years ago (2014-12-13 00:27:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
88e538a78b8b8947183ab626492bd670de6ea090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698