Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 799023003: NaCl cleanup: Remove assignment to g_is_main_thread (Closed)

Created:
6 years ago by Mark Seaborn
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl cleanup: Remove assignment to g_is_main_thread The variable g_is_main_thread is only read from dead code in irt_manifest.c in the NaCl repo. It is read from the old SRPC-based implementation of open_resource(), which isn't accessible because it's overridden by the Chromium side's implementation of open_resource(). Removing this assignment will allow us to remove irt_manifest.c, which defines g_is_main_thread. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 TEST=trybots Committed: https://crrev.com/848bcea8ce9db5ed0c070828133a4cd66934c272 Cr-Commit-Position: refs/heads/master@{#308172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M ppapi/nacl_irt/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/nacl_irt/irt_ppapi.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
6 years ago (2014-12-12 18:03:15 UTC) #2
teravest
lgtm
6 years ago (2014-12-12 18:10:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799023003/1
6 years ago (2014-12-12 19:32:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 21:59:14 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 22:01:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/848bcea8ce9db5ed0c070828133a4cd66934c272
Cr-Commit-Position: refs/heads/master@{#308172}

Powered by Google App Engine
This is Rietveld 408576698