cc: Optimise shared tile handling in eviction tile priority queue.

cc: Optimise shared tile handling in eviction tile priority queue.

As tiling set eviction queue twin pairs do not return shared tiles
twice, eviction tile priority queue does not have to keep track of
shared tiles and filter out duplicated tiles, any more.

Committed: https://crrev.com/59eedaa913eb3bc793ad379718474f9bbaa322e4
Cr-Commit-Position: refs/heads/master@{#308560}

[USE eero AT chromium.org, 2014-12-12 14:56:31]

e.hakkinen@samsung.com changed reviewers:
+ reveman@chromium.org, vmpstr@chromium.org

[USE eero AT chromium.org, 2014-12-12 14:56:31]

This an optimization which was made possibly by my TilingSetEvictionQueue change
(https://codereview.chromium.org/736753002/). PTAL.

[USE eero AT chromium.org, 2014-12-15 12:05:24]

This improves tile_manager_eviction_tile_queue_construct_and_iterate perftest
results by 12 %, on average.

[vmpstr, 2014-12-15 17:33:31]

lgtm with nits

https://codereview.chromium.org/798973002/diff/1/cc/resources/eviction_tile_p...
File cc/resources/eviction_tile_priority_queue.cc (right):

https://codereview.chromium.org/798973002/diff/1/cc/resources/eviction_tile_p...
cc/resources/eviction_tile_priority_queue.cc:170: // If no empty, use Top to do
DCHECK the next iterator.
nit: If not empty

https://codereview.chromium.org/798973002/diff/1/cc/resources/eviction_tile_p...
cc/resources/eviction_tile_priority_queue.cc:171: DCHECK(IsEmpty() ||
Top(tree_priority));
nit: DCHECK_IMPLIES(!IsEmpty(), Top(tree_priority));

[USE eero AT chromium.org, 2014-12-16 08:50:31]

https://codereview.chromium.org/798973002/diff/1/cc/resources/eviction_tile_p...
File cc/resources/eviction_tile_priority_queue.cc (right):

https://codereview.chromium.org/798973002/diff/1/cc/resources/eviction_tile_p...
cc/resources/eviction_tile_priority_queue.cc:170: // If no empty, use Top to do
DCHECK the next iterator.
On 2014/12/15 17:33:31, vmpstr wrote:
> nit: If not empty

Done.

https://codereview.chromium.org/798973002/diff/1/cc/resources/eviction_tile_p...
cc/resources/eviction_tile_priority_queue.cc:171: DCHECK(IsEmpty() ||
Top(tree_priority));
On 2014/12/15 17:33:31, vmpstr wrote:
> nit: DCHECK_IMPLIES(!IsEmpty(), Top(tree_priority));

Done.

[USE eero AT chromium.org, 2014-12-16 08:59:25]

The CQ bit was checked by e.hakkinen@samsung.com

[commit-bot: I haz the power, 2014-12-16 08:59:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/798973002/20001

[commit-bot: I haz the power, 2014-12-16 09:54:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-16 09:55:21]

Patchset 2 (id:??) landed as
https://crrev.com/59eedaa913eb3bc793ad379718474f9bbaa322e4
Cr-Commit-Position: refs/heads/master@{#308560}