Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 798973002: cc: Optimise shared tile handling in eviction tile priority queue. (Closed)

Created:
6 years ago by USE eero AT chromium.org
Modified:
6 years ago
Reviewers:
reveman, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Optimise shared tile handling in eviction tile priority queue. As tiling set eviction queue twin pairs do not return shared tiles twice, eviction tile priority queue does not have to keep track of shared tiles and filter out duplicated tiles, any more. Committed: https://crrev.com/59eedaa913eb3bc793ad379718474f9bbaa322e4 Cr-Commit-Position: refs/heads/master@{#308560}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Minor polish #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -22 lines) Patch
M cc/resources/eviction_tile_priority_queue.h View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/resources/eviction_tile_priority_queue.cc View 1 2 chunks +4 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
USE eero AT chromium.org
This an optimization which was made possibly by my TilingSetEvictionQueue change (https://codereview.chromium.org/736753002/). PTAL.
6 years ago (2014-12-12 14:56:31 UTC) #2
USE eero AT chromium.org
This improves tile_manager_eviction_tile_queue_construct_and_iterate perftest results by 12 %, on average.
6 years ago (2014-12-15 12:05:24 UTC) #3
vmpstr
lgtm with nits https://codereview.chromium.org/798973002/diff/1/cc/resources/eviction_tile_priority_queue.cc File cc/resources/eviction_tile_priority_queue.cc (right): https://codereview.chromium.org/798973002/diff/1/cc/resources/eviction_tile_priority_queue.cc#newcode170 cc/resources/eviction_tile_priority_queue.cc:170: // If no empty, use Top ...
6 years ago (2014-12-15 17:33:31 UTC) #4
USE eero AT chromium.org
https://codereview.chromium.org/798973002/diff/1/cc/resources/eviction_tile_priority_queue.cc File cc/resources/eviction_tile_priority_queue.cc (right): https://codereview.chromium.org/798973002/diff/1/cc/resources/eviction_tile_priority_queue.cc#newcode170 cc/resources/eviction_tile_priority_queue.cc:170: // If no empty, use Top to do DCHECK ...
6 years ago (2014-12-16 08:50:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798973002/20001
6 years ago (2014-12-16 08:59:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-16 09:54:43 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-16 09:55:21 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59eedaa913eb3bc793ad379718474f9bbaa322e4
Cr-Commit-Position: refs/heads/master@{#308560}

Powered by Google App Engine
This is Rietveld 408576698