Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: Source/core/dom/Document.cpp

Issue 798963002: Only populate line number in case parsing synchronously. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index 5a09d1d367578cc53657d00fa5ce5ccae1876ee8..f31f5c675cd493afd0f8a4de76ddcb49a7e61016 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -5004,9 +5004,9 @@ void Document::addConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage> consoleM
if (!consoleMessage->scriptState() && consoleMessage->url().isNull() && !consoleMessage->lineNumber()) {
consoleMessage->setURL(url().string());
- if (!consoleMessage->isAsync() && parsing() && !isInDocumentWrite() && scriptableDocumentParser()) {
+ if (!isInDocumentWrite() && scriptableDocumentParser()) {
ScriptableDocumentParser* parser = scriptableDocumentParser();
- if (!parser->isWaitingForScripts() && !parser->isExecutingScript())
+ if (parser->hasLineNumber() && !parser->isWaitingForScripts() && !parser->isExecutingScript())
consoleMessage->setLineNumber(parser->lineNumber().oneBasedInt());
}
}
« no previous file with comments | « no previous file | Source/core/dom/ScriptableDocumentParser.h » ('j') | Source/core/dom/ScriptableDocumentParser.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698