Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 798963002: Only populate line number in case parsing synchronously. (Closed)

Created:
6 years ago by pfeldman
Modified:
6 years ago
Reviewers:
rmcilroy
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis, caseq+blink_chromium.org, malch+blink_chromium.org, blink-reviews-html_chromium.org, yurys+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Only populate line number in case parsing synchronously. (needs some rebaselines) BUG=436582, 432129 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187094

Patch Set 1 #

Total comments: 6

Patch Set 2 : with rebaselined tests. #

Total comments: 4

Patch Set 3 : for landing #

Patch Set 4 : deleted custom mac expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -53 lines) Patch
M LayoutTests/http/tests/misc/image-blocked-src-change-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/image-blocked-src-no-change-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/image-blocked-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-empty-srcset-in-main-frame-blocked-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-image-in-iframe-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-picture-in-main-frame-blocked-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-srcset-in-main-frame-blocked-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/no-javascript-refresh-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xss-DENIED-xsl-document-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/platform/mac/http/tests/misc/image-blocked-src-change-expected.txt View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ScriptableDocumentParser.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ScriptableDocumentParser.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 2 3 5 chunks +10 lines, -0 lines 0 comments Download
M Source/core/inspector/ConsoleMessage.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/inspector/ConsoleMessage.cpp View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
pfeldman
6 years ago (2014-12-12 14:02:14 UTC) #2
rmcilroy
I like this, thanks for doing it! A couple of comments but otherwise lgtm. https://codereview.chromium.org/798963002/diff/1/Source/core/dom/ScriptableDocumentParser.h ...
6 years ago (2014-12-12 14:18:32 UTC) #3
pfeldman
https://codereview.chromium.org/798963002/diff/1/Source/core/dom/ScriptableDocumentParser.h File Source/core/dom/ScriptableDocumentParser.h (right): https://codereview.chromium.org/798963002/diff/1/Source/core/dom/ScriptableDocumentParser.h#newcode48 Source/core/dom/ScriptableDocumentParser.h:48: virtual bool hasLineNumber() const = 0; On 2014/12/12 14:18:31, ...
6 years ago (2014-12-12 17:21:06 UTC) #4
pfeldman
https://codereview.chromium.org/798963002/diff/20001/LayoutTests/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt File LayoutTests/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt (right): https://codereview.chromium.org/798963002/diff/20001/LayoutTests/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt#newcode1 LayoutTests/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt:1: CONSOLE ERROR: Refused to execute script from 'http://127.0.0.1:8000/security/contentTypeOptions/resources/script-with-header.pl' because ...
6 years ago (2014-12-12 17:22:53 UTC) #5
rmcilroy
LGTM, thanks! https://codereview.chromium.org/798963002/diff/20001/Source/core/html/parser/HTMLDocumentParser.h File Source/core/html/parser/HTMLDocumentParser.h (right): https://codereview.chromium.org/798963002/diff/20001/Source/core/html/parser/HTMLDocumentParser.h#newcode207 Source/core/html/parser/HTMLDocumentParser.h:207: bool m_hasLineNumber; nit - m_isParsingAtLineNumber
6 years ago (2014-12-12 17:24:32 UTC) #6
pfeldman
https://codereview.chromium.org/798963002/diff/20001/Source/core/html/parser/HTMLDocumentParser.h File Source/core/html/parser/HTMLDocumentParser.h (right): https://codereview.chromium.org/798963002/diff/20001/Source/core/html/parser/HTMLDocumentParser.h#newcode207 Source/core/html/parser/HTMLDocumentParser.h:207: bool m_hasLineNumber; On 2014/12/12 17:24:31, rmcilroy wrote: > nit ...
6 years ago (2014-12-12 19:14:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798963002/40001
6 years ago (2014-12-12 19:15:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/41337)
6 years ago (2014-12-12 21:48:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798963002/60001
6 years ago (2014-12-13 08:44:42 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-13 11:05:06 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187094

Powered by Google App Engine
This is Rietveld 408576698