Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 798943003: Call CloseClipboard() with anonymous access token. (Closed)

Created:
6 years ago by Sergey Ulanov
Modified:
6 years ago
Reviewers:
Wez
CC:
chromium-reviews, dcheng, chromoting-reviews_chromium.org, jschuh, forshaw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call CloseClipboard() with anonymous access token. Windows API makes it possible to impersonate access token of the last process that called CloseClipboard(). Chromoting calls it from a system process, so it has to impersonate anonymous token before calling CloseClipboard(). BUG=441834 Committed: https://crrev.com/60f87ce4c93659d34e5d996aada4288d3c793c7b Cr-Commit-Position: refs/heads/master@{#308155}

Patch Set 1 #

Patch Set 2 #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M remoting/host/clipboard_win.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sergey Ulanov
6 years ago (2014-12-12 18:53:36 UTC) #2
Wez
lgtm https://codereview.chromium.org/798943003/diff/20001/remoting/host/clipboard_win.cc File remoting/host/clipboard_win.cc (right): https://codereview.chromium.org/798943003/diff/20001/remoting/host/clipboard_win.cc#newcode38 remoting/host/clipboard_win.cc:38: CHECK(result); nit: I think it'd be acceptable to ...
6 years ago (2014-12-12 19:25:36 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/798943003/diff/20001/remoting/host/clipboard_win.cc File remoting/host/clipboard_win.cc (right): https://codereview.chromium.org/798943003/diff/20001/remoting/host/clipboard_win.cc#newcode38 remoting/host/clipboard_win.cc:38: CHECK(result); On 2014/12/12 19:25:36, Wez wrote: > nit: I ...
6 years ago (2014-12-12 19:34:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798943003/40001
6 years ago (2014-12-12 19:38:16 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-12 20:47:37 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-12 20:48:18 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/60f87ce4c93659d34e5d996aada4288d3c793c7b
Cr-Commit-Position: refs/heads/master@{#308155}

Powered by Google App Engine
This is Rietveld 408576698