Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 798903003: Adding telemetry WebRTC measurements for the audio codecs we support. (Closed)

Created:
6 years ago by phoglund_chromium
Modified:
6 years ago
Reviewers:
qyearsley
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding telemetry WebRTC measurements for the audio codecs we support. We'll now measure vital statistics for all audio codecs we support, notably the CPU usage of the various codecs. The results on by Linux box suggests Opus is the most expensive codec (but it presumably sounds better). It will be interesting to see what results we will see on Android and ChromeOS devices. BUG=413577 Committed: https://crrev.com/efb8ed2ebbfa8403c7231c7cf6af787e4d13588d Cr-Commit-Position: refs/heads/master@{#308338}

Patch Set 1 #

Patch Set 2 : Adding wpr #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -4 lines) Patch
M tools/perf/page_sets/data/webrtc_cases.json View 2 chunks +8 lines, -4 lines 0 comments Download
A tools/perf/page_sets/data/webrtc_cases_009.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/webrtc_cases.py View 1 2 2 chunks +71 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
phoglund_chromium
6 years ago (2014-12-12 10:29:57 UTC) #2
qyearsley
On 2014/12/12 10:29:57, phoglund wrote: Don't see any problems, lgtm.
6 years ago (2014-12-14 01:49:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798903003/20001
6 years ago (2014-12-15 09:45:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/36513) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/37655)
6 years ago (2014-12-15 09:47:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798903003/40001
6 years ago (2014-12-15 10:09:05 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-15 12:06:36 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-15 12:07:16 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/efb8ed2ebbfa8403c7231c7cf6af787e4d13588d
Cr-Commit-Position: refs/heads/master@{#308338}

Powered by Google App Engine
This is Rietveld 408576698