Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

Issue 798873004: dart2js: change output so that in stack traces, dart method names get prefixed with 'dart.' instead… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
index af179f8b996b73040b0ffbb405e2d1baf46d2b3f..d54361e205361a47576d9b41f8176335a56c15b4 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
@@ -53,15 +53,6 @@ jsAst.Expression getReflectionDataParser(OldEmitter oldEmitter,
jsAst.Expression metadataAccess =
emitter.generateEmbeddedGlobalAccess(embeddedNames.METADATA);
- jsAst.Statement header = js.statement('''
-// [map] returns an object literal that V8 shouldn not try to optimize with a
-// hidden class. This prevents a potential performance problem where V8 tries
-// to build a hidden class for an object used as a hashMap.
-// It requires fewer characters to declare a variable as a parameter than
-// with `var`.
- function map(x){x=Object.create(null);x.x=0;delete x.x;return x}
-''');
-
jsAst.Statement processClassData = js.statement('''{
function processClassData(cls, descriptor, processedClasses) {
var newDesc = {};
@@ -429,7 +420,6 @@ jsAst.Expression getReflectionDataParser(OldEmitter oldEmitter,
return js('''
function $parseReflectionDataName(reflectionData) {
"use strict";
- #header;
if (#needsClassSupport) {
#defineClass;
#inheritFrom;
@@ -442,7 +432,6 @@ function $parseReflectionDataName(reflectionData) {
#incrementalSupport;
#init;
}''', {
- 'header': header,
'defineClass': oldEmitter.defineClassFunction,
'inheritFrom': oldEmitter.buildInheritFrom(),
'processClassData': processClassData,

Powered by Google App Engine
This is Rietveld 408576698