content/browser/service_worker/service_worker_registration.cc - Issue 798833002: ServiceWorker: Make skipWaiting only works on documents using current registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.cc

Issue 798833002: ServiceWorker: Make skipWaiting only works on documents using current registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: typo fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/service_worker/service_worker_registration.cc

diff --git a/content/browser/service_worker/service_worker_registration.cc b/content/browser/service_worker/service_worker_registration.cc

index 7d41454f4adab012710e26305a44a4d697bb03e5..a4fac5c65873a9c9afe96c3b0e8b6fa92fe493b0 100644

--- a/content/browser/service_worker/service_worker_registration.cc

+++ b/content/browser/service_worker/service_worker_registration.cc

@@ -266,7 +266,6 @@ void ServiceWorkerRegistration::ActivateWaitingVersion() {

// "activating" as arguments."

activating_version->SetStatus(ServiceWorkerVersion::ACTIVATING);

// "9. Fire a simple event named controllerchange..."

- // Notify associated provider hosts to change the controller.

if (activating_version->skip_waiting())

FOR_EACH_OBSERVER(Listener, listeners_, OnSkippedWaiting(this));

« no previous file with comments | « content/browser/service_worker/service_worker_provider_host.cc ('k') | no next file » | no next file with comments »