Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: content/browser/service_worker/service_worker_registration.cc

Issue 798833002: ServiceWorker: Make skipWaiting only works on documents using current registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_registration.cc
diff --git a/content/browser/service_worker/service_worker_registration.cc b/content/browser/service_worker/service_worker_registration.cc
index 7d41454f4adab012710e26305a44a4d697bb03e5..a913f816029d7c7e827d2aedf9d983af65398a8d 100644
--- a/content/browser/service_worker/service_worker_registration.cc
+++ b/content/browser/service_worker/service_worker_registration.cc
@@ -266,7 +266,8 @@ void ServiceWorkerRegistration::ActivateWaitingVersion() {
// "activating" as arguments."
activating_version->SetStatus(ServiceWorkerVersion::ACTIVATING);
// "9. Fire a simple event named controllerchange..."
- // Notify associated provider hosts to change the controller.
+ // Only provider hots are currently using this registeration will change the
+ // controller.
falken 2014/12/15 02:29:25 nit: This comment probably works better in OnSkipp
xiang 2014/12/15 06:00:52 Done.
if (activating_version->skip_waiting())
FOR_EACH_OBSERVER(Listener, listeners_, OnSkippedWaiting(this));

Powered by Google App Engine
This is Rietveld 408576698