Chromium Code Reviews
Help | Chromium Project | Sign in
(157)

Issue 7988008: Make check_licenses about 5x faster. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by Paweł Hajdan Jr.
Modified:
2 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Make check_licenses about 5x faster.

I've used a profiler and removed code that takes long time
bug we don't use, and optimized several regular expressions.

BUG=28291
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -69 lines) Lint Patch
M third_party/devscripts/chromium-1.patch View 4 chunks +89 lines, -17 lines 0 comments ? errors Download
M third_party/devscripts/licensecheck.pl View 7 chunks +8 lines, -39 lines 0 comments ? errors Download
M tools/checklicenses/checklicenses.py View 9 chunks +6 lines, -13 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Paweł Hajdan Jr.
2 years, 7 months ago #1
Evan Martin
2 years, 7 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6