Chromium Code Reviews
Help | Chromium Project | Sign in
(136)

Issue 7988008: Make check_licenses about 5x faster. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 9 months ago by Paweł Hajdan Jr.
Modified:
3 years, 9 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Make check_licenses about 5x faster. I've used a profiler and removed code that takes long time bug we don't use, and optimized several regular expressions. BUG=28291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -69 lines) Patch
M third_party/devscripts/chromium-1.patch View 4 chunks +89 lines, -17 lines 0 comments Download
M third_party/devscripts/licensecheck.pl View 7 chunks +8 lines, -39 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 9 chunks +6 lines, -13 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
3 years, 9 months ago (2011-09-22 17:54:04 UTC) #1
Evan Martin
3 years, 9 months ago (2011-09-22 17:57:05 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d