Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 798793003: Add new complexclip3 gm. (Closed)

Created:
6 years ago by egdaniel
Modified:
6 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add new complexclip3 gm. This GM is used to test the combined clipping of a complex clip (packman shape) and a simple one (circle). We loop over all combinations of clip ops, aa/bw clip, and inverse/non-inverse clips. This GM triggers a current bug in the gpu clipping code which fires an assert. Thus the skipGPU flag is set until that bug is fixed. BUG=skia: Committed: https://skia.googlesource.com/skia/+/df795036fdff68d0c3e1d53d50e1e3777df88668

Patch Set 1 #

Total comments: 6

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -0 lines) Patch
A gm/complexclip3.cpp View 1 1 chunk +136 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
egdaniel
6 years ago (2014-12-17 19:02:54 UTC) #2
bsalomon
lgtm with nits https://codereview.chromium.org/798793003/diff/1/gm/complexclip3.cpp File gm/complexclip3.cpp (right): https://codereview.chromium.org/798793003/diff/1/gm/complexclip3.cpp#newcode3 gm/complexclip3.cpp:3: * Copyright 2011 Google Inc. 2014 ...
6 years ago (2014-12-17 19:07:22 UTC) #3
bsalomon
lgtm with nits
6 years ago (2014-12-17 19:07:23 UTC) #4
egdaniel
https://codereview.chromium.org/798793003/diff/1/gm/complexclip3.cpp File gm/complexclip3.cpp (right): https://codereview.chromium.org/798793003/diff/1/gm/complexclip3.cpp#newcode3 gm/complexclip3.cpp:3: * Copyright 2011 Google Inc. On 2014/12/17 19:07:22, bsalomon ...
6 years ago (2014-12-17 19:13:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798793003/20001
6 years ago (2014-12-17 19:14:15 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-17 19:22:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/df795036fdff68d0c3e1d53d50e1e3777df88668

Powered by Google App Engine
This is Rietveld 408576698