Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: sdk/lib/io/process.dart

Issue 798743004: Add support for starting a detached process (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Minor fixes + rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/io/process.dart
diff --git a/sdk/lib/io/process.dart b/sdk/lib/io/process.dart
index de3b0e5e63e2578896f55ef59925b56a9583fc63..cacad32540aa78de669f1d6cccfa677b32e1599b 100644
--- a/sdk/lib/io/process.dart
+++ b/sdk/lib/io/process.dart
@@ -241,7 +241,7 @@ abstract class Process {
* include the parent process's environment, with [environment] taking
* precedence. Default is `true`.
*
- * If [runInShell] is true, the process will be spawned through a system
+ * If [runInShell] is `true`, the process will be spawned through a system
* shell. On Linux and Mac OS, [:/bin/sh:] is used, while
* [:%WINDIR%\system32\cmd.exe:] is used on Windows.
Lasse Reichstein Nielsen 2015/01/15 09:55:40 What practical difference does it make to run thro
*
@@ -257,6 +257,13 @@ abstract class Process {
* stdout.addStream(process.stdout);
* stderr.addStream(process.stderr);
* });
+ *
+ * If [detached] is `true` a detached process will be created. A
+ * detached process does have any connection to its parent and can
Lasse Reichstein Nielsen 2015/01/15 09:55:39 does -> does not or better: does have -> has no ?
Søren Gjesse 2015/01/21 12:32:35 Done.
+ * keep running on its own when the parent dies. The only
+ * information available from a detached process is its `pid`. There
+ * will be no connection to its `stdout` or `stderr` nor will its
+ * exit code become available when it terminates.
*/
external static Future<Process> start(
String executable,
@@ -264,7 +271,8 @@ abstract class Process {
{String workingDirectory,
Map<String, String> environment,
bool includeParentEnvironment: true,
- bool runInShell: false});
+ bool runInShell: false,
+ bool detached: false});
Lasse Reichstein Nielsen 2015/01/15 09:55:39 Other boolean argument names are imperative, this
kustermann 2015/01/16 16:11:04 Are you sure we should return a Process object her
Søren Gjesse 2015/01/21 12:32:35 Done.
Søren Gjesse 2015/01/21 12:32:35 Process.start is the Swiss army knife for starting
/**
* Starts a process and runs it non-interactively to completion. The

Powered by Google App Engine
This is Rietveld 408576698