Always emit original sources from scan_sources.

Always emit original sources from scan_sources.

scan_sources.py should always emit the original source files passed as input,
even if it cannot find them. This is necessary to create a proper dependency
arc from the build rule "mojo_nacl" to the generated source "libmojo.cc" from
the "monacl_codegen" build rule..

It's not sufficient to convey this source dependency through ninja depfiles.
This is because the emitted dependency in the mojo_nacl.ninja from "mojo_nacl"
to "monacl_codegen" is order-only and depenencies are scanned before order-only
dependencies are run (https://github.com/martine/ninja/issues/760).

BUG=https://code.google.com/p/chromium/issues/detail?id=440451
TEST=manually modified libmojo.cc.tmpl and rebuilt mojo_nacl.
R=bradnelson@google.com, ncbray@chromium.org

Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=14212

[teravest, 2014-12-11 22:12:07]

teravest@chromium.org changed reviewers:
+ bradnelson@chromium.org, ncbray@chromium.org

[teravest, 2014-12-11 23:38:04]

teravest@chromium.org changed reviewers:
+ bradnelson@chromium.org, ncbray@chromium.org

[bradn, 2014-12-11 23:43:37]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2014-12-11 23:43:37]

lgtm

[Nick Bray (chromium), 2014-12-12 00:24:17]

LGTM w/ comment.

https://codereview.chromium.org/798733002/diff/1/build/scan_sources.py
File build/scan_sources.py (right):

https://codereview.chromium.org/798733002/diff/1/build/scan_sources.py#newcod...
build/scan_sources.py:293: # If any of the original files requested aren't
found, add them anyway.
Why? Comment.

[teravest, 2014-12-12 15:03:00]

https://codereview.chromium.org/798733002/diff/1/build/scan_sources.py
File build/scan_sources.py (right):

https://codereview.chromium.org/798733002/diff/1/build/scan_sources.py#newcod...
build/scan_sources.py:293: # If any of the original files requested aren't
found, add them anyway.
On 2014/12/12 00:24:17, Nick Bray (chromium) wrote:
> Why? Comment.

Done.

[teravest, 2014-12-12 15:32:57]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-12-12 15:33:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/798733002/20001

[teravest, 2014-12-12 17:32:20]

Patchset #3 (id:40001) has been deleted

[teravest, 2014-12-12 17:32:24]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-12-12 17:33:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/798733002/20001

[commit-bot: I haz the power, 2014-12-12 22:02:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-12 22:02:41]

Try jobs failed on following builders:
  nacl-arm_opt_panda on tryserver.nacl
(http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_opt_panda/builds...)

[teravest, 2014-12-12 22:16:07]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-12-12 22:16:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/798733002/20001

[teravest, 2014-12-12 22:17:01]

Committed patchset #2 (id:20001) manually as 14212 (presubmit successful).