Issue 79873002: [VS Addin] Set the 'NonCoreWin' property to 'true'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 79873002: [VS Addin] Set the 'NonCoreWin' property to 'true' (Closed)

Created:
7 years, 1 month ago by Sam Clegg

Modified:
7 years, 1 month ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
https://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

[VS Addin] Set the 'NonCoreWin' property to 'true' Without this the MS build files for 2012 were adding the core windows libraries to the list of dependencies. This fixes the 2012 tests which are currently failing on the bots. R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1568

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	visual_studio/NativeClientVSAddIn/InstallerResources/NaCl64/Microsoft.Cpp.NaCl64.props	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Sam Clegg

7 years, 1 month ago (2013-11-21 00:26:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r1568 (presubmit successful).