Fix copying from interstitial pages on OSX.

content/browser/renderer_host/render_widget_host_view_mac.mm

Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index 8599a310edbb7791982d4f11766df4c50cac1534..eb9b2c3bdee3ef3d10c5826d028d2453ca9229ed 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -1410,8 +1410,8 @@ WebContents* RenderWidgetHostViewMac::GetWebContents() {
   if (!render_widget_host_->IsRenderView())
     return NULL;
 
-  return WebContents::FromRenderViewHost(
-      RenderViewHost::From(render_widget_host_));
+  return WebContents::FromRenderFrameHost(

[Charlie Reis, 2015/04/28 22:37:27]

I'm looking at some of the GetAsWebContents() call sites within this class, and
some of them seem like they would be wrong with your current change.  (There's
no cross-linking for Mac in codesearch, so I'm not sure if this function has
other call sites that might be broken as well.)

For example, GetRenderWidgetHostViewToUse looks wrong.  Given a RWHVM, this
returns it unless there's a full screen guest (e.g., for signin).  However, if
we call it with an interstitial's RWHVM (e.g., if we navigate to a broken HTTPS
tab while signin is showing), we would expect to get back the interstitial's
RWVHM but instead we'd get the (now hidden) guest's RWHVM.  As a result,
startSpeaking and stopSpeaking would read hidden text instead of what's showing
on the interstitial.

undo, redo, cut, copy, etc admittedly look like they need to send InputMsgs to
the focused frame of the interstitial page if an interstitial is showing.  Going
through WebContents and changing GetFocusedFrame might work, but I feel like
there's probably a better way to handle it than causing this confusion between
the WebContents and interstitial.

Here's a proposal...  What if undo, redo, etc called methods on the
RenderWidgetHostDelegate of render_widget_host_?  On WebContents, this would use
the existing Undo, Redo, etc methods that pass IPCs to its focused frame.  On
InterstitialPageImpl, this would do essentially the same thing but using the
*interstitial page's* frame_tree_.GetFocusedFrame().

We might end up with some code duplication for those simple methods, and we
might have to expose RWHI's delegate, but we would end up sending the commands
to the right places and not have any new places to worry about confusing the
interstitial and the WebContents.  Would that work?

+      RenderViewHost::From(render_widget_host_)->GetMainFrame());
 }
 
 bool RenderWidgetHostViewMac::GetCachedFirstRectForCharacterRange(