Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: content/browser/frame_host/interstitial_page_impl.h

Issue 798723004: Fix copying from interstitial pages on OSX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Verified test. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/interstitial_page_impl.h
diff --git a/content/browser/frame_host/interstitial_page_impl.h b/content/browser/frame_host/interstitial_page_impl.h
index f8aa8a7c4c70890f831cb187f132e7047a5ef079..b7b068eb8eecd0959d393bf6cda82ad832a2881f 100644
--- a/content/browser/frame_host/interstitial_page_impl.h
+++ b/content/browser/frame_host/interstitial_page_impl.h
@@ -63,6 +63,7 @@ class CONTENT_EXPORT InterstitialPageImpl
void Proceed() override;
RenderFrameHost* GetMainFrame() const override;
InterstitialPageDelegate* GetDelegateForTesting() override;
+ WebContents* GetAsWebContents() override;
nasko 2015/04/22 05:07:45 This doesn't seem right. This is not a WebContents
lgarron 2015/04/22 07:19:54 I think we have to do this to overwrite RenderView
void DontCreateViewForTesting() override;
void SetSize(const gfx::Size& size) override;
void Focus() override;
@@ -89,6 +90,7 @@ class CONTENT_EXPORT InterstitialPageImpl
void DidNavigate(
RenderViewHost* render_view_host,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
+ FrameTree* GetFrameTree() override;
nasko 2015/04/22 05:07:45 Why do you need to expose this? Can't we use GetMa
lgarron 2015/04/22 07:19:53 This is what we came up with when we originally ma
protected:
// NotificationObserver method:
@@ -137,8 +139,6 @@ class CONTENT_EXPORT InterstitialPageImpl
SessionStorageNamespace* GetSessionStorageNamespace(
SiteInstance* instance) override;
- FrameTree* GetFrameTree() override;
-
// RenderWidgetHostDelegate implementation:
void RenderWidgetDeleted(RenderWidgetHostImpl* render_widget_host) override;
bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,

Powered by Google App Engine
This is Rietveld 408576698