Fix copying from interstitial pages on OSX.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
@@ skipping 627 matching lines @@
 RenderProcessHost* WebContentsImpl::GetRenderProcessHost() const {
   RenderViewHostImpl* host = GetRenderManager()->current_host();
   return host ? host->GetProcess() : NULL;
 }
 
 RenderFrameHostImpl* WebContentsImpl::GetMainFrame() {
   return frame_tree_.root()->current_frame_host();
 }
 
 RenderFrameHost* WebContentsImpl::GetFocusedFrame() {
+  if (ShowingInterstitialPage()) {
+    InterstitialPageImpl* interstitial_page =
+        static_cast<InterstitialPageImpl*>(GetInterstitialPage());
+    return interstitial_page->GetMainFrame();

[Charlie Reis, 2015/04/27 23:39:26]

This is mildly scary to me.  We're returning a frame that is not in the frame
tree of the WebContents, which could have undefined behavior in any call sites
that make that assumption.

Maybe it's reasonable since this is specific to focus and kind of makes sense
conceptually, but it feels really risky to me.

+  }
   if (!frame_tree_.GetFocusedFrame())
     return NULL;
   return frame_tree_.GetFocusedFrame()->current_frame_host();
 }
 
 void WebContentsImpl::ForEachFrame(
     const base::Callback<void(RenderFrameHost*)>& on_frame) {
   frame_tree_.ForEach(base::Bind(&ForEachFrameInternal, on_frame));
 }
 
@@ skipping 3765 matching lines @@
   node->render_manager()->ResumeResponseDeferredAtStart();
 }
 
 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) {
   force_disable_overscroll_content_ = force_disable;
   if (view_)
     view_->SetOverscrollControllerEnabled(CanOverscrollContent());
 }
 
 }  // namespace content