Fix copying from interstitial pages on OSX.

content/browser/frame_host/interstitial_page_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/interstitial_page_impl.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 682 matching lines @@
 }
 
 RenderFrameHost* InterstitialPageImpl::GetMainFrame() const {
   return render_view_host_->GetMainFrame();
 }
 
 InterstitialPageDelegate* InterstitialPageImpl::GetDelegateForTesting() {
   return delegate_.get();
 }
 
+WebContents* InterstitialPageImpl::GetAsWebContents() {
+  return web_contents_;

[Charlie Reis, 2015/04/27 23:39:26]

This feels super risky to me.

If callers hear something from an interstitial RenderFrameHost and assume it's
from the WebContents, it's really easy for them to confuse the interstitial's
URL or process with the last committed URL or process in the WebContents.  That
could be a big security bug if the last committed page is a WebUI and the
interstitial is for an untrusted page.

+}
+
 void InterstitialPageImpl::DontCreateViewForTesting() {
   create_view_ = false;
 }
 
 gfx::Rect InterstitialPageImpl::GetRootWindowResizerRect() const {
   return gfx::Rect();
 }
 
 void InterstitialPageImpl::CreateNewWindow(
     int render_process_id,
@@ skipping 181 matching lines @@
 void InterstitialPageImpl::UnderlyingContentObserver::NavigationEntryCommitted(
     const LoadCommittedDetails& load_details) {
   interstitial_->OnNavigatingAwayOrTabClosing();
 }
 
 void InterstitialPageImpl::UnderlyingContentObserver::WebContentsDestroyed() {
   interstitial_->OnNavigatingAwayOrTabClosing();
 }
 
 }  // namespace content