Fix copying from interstitial pages on OSX.

content/browser/web_contents/web_contents_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/frame_host/cross_site_transferring_request.h"
 #include "content/browser/frame_host/interstitial_page_impl.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
@@ skipping 2256 matching lines @@
   // While the interstitial is showing, let's simulate the hidden page
   // attempting to show a JS message.
   IPC::Message* dummy_message = new IPC::Message;
   contents()->RunJavaScriptMessage(contents()->GetMainFrame(),
       base::ASCIIToUTF16("This is an informative message"),
       base::ASCIIToUTF16("OK"),
       kGURL, JAVASCRIPT_MESSAGE_TYPE_ALERT, dummy_message);
   EXPECT_TRUE(contents()->last_dialog_suppressed_);
 }
 
+// Tests that GetFocusedFrame() does not return NULL for an interstitial.
+// This is is needed for copying from interstitials on OSX: crbug.com/415784
+TEST_F(WebContentsImplTest, CanGetFocusedFrameInInterstitial) {
+  // Show an interstitial.
+  TestInterstitialPage::InterstitialState state =
+      TestInterstitialPage::INVALID;
+  bool deleted = false;
+  GURL interstitial_url("http://interstitial");
+  TestInterstitialPage* interstitial =
+      new TestInterstitialPage(contents(), true, interstitial_url,
+                               &state, &deleted);
+  TestInterstitialPageStateGuard state_guard(interstitial);
+  interstitial->Show();
+
+  // Now let's make the interstitial navigation commit.
+  interstitial->TestDidNavigate(1, interstitial_url);
+
+  // Test that we can get GetFocusedFrame().
+  EXPECT_NE(nullptr, interstitial->GetAsWebContents()->GetFocusedFrame());

[nasko, 2015/04/22 05:07:45]

Let's add accessor that exposes the associated WebContents in
TestInterstitialPage. This way it is only usable in tests and we avoid APIs on
the original object that can be misused.

[lgarron, 2015/04/22 07:19:54]

As of a week ago, InterstitialPageImpl has a protected web_contents() function
that makes this easy, but given that we need GetAsWebContents() [see above] to
be a public override I think it makes sense to keep this?

+

[nasko, 2015/04/22 05:07:45]

I think we can another expectation here. The RenderFrameHost we get back from
WebContents::GetFocusedFrame() while an interstitial page is displayed should be
different than WebContents::GetMainFrame(), not just non-null.

[lgarron, 2015/04/22 07:19:54]

Done.

+  EXPECT_FALSE(deleted);
+}
+
 // Makes sure that if the source passed to CopyStateFromAndPrune has an
 // interstitial it isn't copied over to the destination.
 TEST_F(WebContentsImplTest, CopyStateFromAndPruneSourceInterstitial) {
   // Navigate to a page.
   GURL url1("http://www.google.com");
   main_test_rfh()->NavigateAndCommitRendererInitiated(1, url1);
   EXPECT_EQ(1, controller().GetEntryCount());
 
   // Initiate a browser navigation that will trigger the interstitial
   controller().LoadURL(GURL("http://www.evil.com"), Referrer(),
@@ skipping 754 matching lines @@
   contents()->GetMainFrame()->OnMessageReceived(
       FrameHostMsg_RenderProcessGone(
           0, base::TERMINATION_STATUS_PROCESS_CRASHED, -1));
 
   // Verify that all the power save blockers have been released.
   EXPECT_FALSE(contents()->has_video_power_save_blocker_for_testing());
   EXPECT_FALSE(contents()->has_audio_power_save_blocker_for_testing());
 }
 
 }  // namespace content