Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 798723002: More win64 warning fixes (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@size_t
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : whitespace #

Patch Set 3 : off_t is signed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -28 lines) Patch
M dm/DMWriteTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/tallstretchedbitmaps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkTypes.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M src/core/SkDebug.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkDistanceFieldGen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkDistanceFieldGen.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrProgramDesc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSWMaskHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFCatalog.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDocument.cpp View 3 chunks +8 lines, -12 lines 0 comments Download
M src/sfnt/SkOTUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
bsalomon
6 years ago (2014-12-12 14:53:19 UTC) #6
mtklein
lgtm
6 years ago (2014-12-12 15:18:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798723002/20001
6 years ago (2014-12-12 15:24:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1122) Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1112)
6 years ago (2014-12-12 15:25:42 UTC) #11
reed1
lgtm
6 years ago (2014-12-12 16:23:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798723002/40001
6 years ago (2014-12-12 16:32:53 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-12 16:51:45 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ef3fcd877aa78c1d0ac802043cd8785180304c12

Powered by Google App Engine
This is Rietveld 408576698