Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: src/IceInstX8632.h

Issue 798693003: Subzero: Don't store std::string objects inside Variable. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Code review changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceInst.cpp ('k') | src/IceOperand.h » ('j') | src/IceOperand.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstX8632.h
diff --git a/src/IceInstX8632.h b/src/IceInstX8632.h
index 5d10a544ad97ae084d675e42674d7b1a976f1660..cc44a1aa5763c80d54999a3090372a9fc038895d 100644
--- a/src/IceInstX8632.h
+++ b/src/IceInstX8632.h
@@ -152,9 +152,8 @@ class SpillVariable : public Variable {
SpillVariable &operator=(const SpillVariable &) = delete;
public:
- static SpillVariable *create(Cfg *Func, Type Ty, SizeT Index,
- const IceString &Name) {
- return new (Func->allocate<SpillVariable>()) SpillVariable(Ty, Index, Name);
+ static SpillVariable *create(Cfg *Func, Type Ty, SizeT Index) {
+ return new (Func->allocate<SpillVariable>()) SpillVariable(Ty, Index);
}
const static OperandKind SpillVariableKind =
static_cast<OperandKind>(kVariable_Target);
@@ -165,8 +164,8 @@ public:
Variable *getLinkedTo() const { return LinkedTo; }
// Inherit dump() and emit() from Variable.
private:
- SpillVariable(Type Ty, SizeT Index, const IceString &Name)
- : Variable(SpillVariableKind, Ty, Index, Name), LinkedTo(NULL) {}
+ SpillVariable(Type Ty, SizeT Index)
+ : Variable(SpillVariableKind, Ty, Index), LinkedTo(NULL) {}
Variable *LinkedTo;
};
« no previous file with comments | « src/IceInst.cpp ('k') | src/IceOperand.h » ('j') | src/IceOperand.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698