Subzero: Don't store std::string objects inside Variable.

src/PNaClTranslator.cpp

Index: src/PNaClTranslator.cpp
diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp
index 8f1f99dfaeaf9446d1f2799b1f28255837b5e519..61af819fc305334a8c7043255ffa613db073d35c 100644
--- a/src/PNaClTranslator.cpp
+++ b/src/PNaClTranslator.cpp
@@ -1086,8 +1086,6 @@ void ValuesymtabParser::ProcessRecord() {
   return;
 }
 
-class FunctionValuesymtabParser;

[Jim Stichnoth, 2014/12/11 20:54:00]

Happened to notice that this forward declaration is (no longer) necessary.

-
 /// Parses function blocks in the bitcode file.
 class FunctionParser : public BlockParserBaseClass {
   FunctionParser(const FunctionParser &) = delete;
@@ -2664,7 +2662,7 @@ void FunctionValuesymtabParser::setValueName(uint64_t Index, StringType &Name) {
   Ice::Operand *Op = getFunctionParser()->getOperand(Index);
   if (Ice::Variable *V = dyn_cast<Ice::Variable>(Op)) {
     std::string Nm(Name.data(), Name.size());
-    V->setName(Nm);
+    V->setName(getFunctionParser()->getFunc(), Nm);
   } else {
     reportUnableToAssign("variable", Index, Name);
   }