Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 798583003: Encrypted Media: Check "alg":"A128KW" in AesDecryptor. (Closed)

Created:
6 years ago by xhwang
Modified:
6 years ago
Reviewers:
jrummell
CC:
chromium-reviews, eme-reviews_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Encrypted Media: Check "alg":"A128KW" in AesDecryptor. BUG=444713 TEST=Add tests to cover this case. R=jrummell@chromium.org Committed: https://crrev.com/5287c3c5dba8723c07761f291dc7f710c9d98064 Cr-Commit-Position: refs/heads/master@{#309543}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix AesDecryptorTest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -56 lines) Patch
M media/cdm/aes_decryptor.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 1 12 chunks +13 lines, -0 lines 0 comments Download
M media/cdm/json_web_key.cc View 7 chunks +31 lines, -11 lines 0 comments Download
M media/cdm/json_web_key_unittest.cc View 8 chunks +189 lines, -41 lines 0 comments Download
M media/test/data/eme_player_js/utils.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
xhwang
6 years ago (2014-12-22 23:57:23 UTC) #1
jrummell
lgtm w/nit. https://codereview.chromium.org/798583003/diff/1/media/cdm/json_web_key_unittest.cc File media/cdm/json_web_key_unittest.cc (left): https://codereview.chromium.org/798583003/diff/1/media/cdm/json_web_key_unittest.cc#oldcode147 media/cdm/json_web_key_unittest.cc:147: ExtractJWKKeysAndExpect("{ \"keys\": [] }", true, 0); Why ...
6 years ago (2014-12-23 00:41:21 UTC) #2
xhwang
https://codereview.chromium.org/798583003/diff/1/media/cdm/json_web_key_unittest.cc File media/cdm/json_web_key_unittest.cc (left): https://codereview.chromium.org/798583003/diff/1/media/cdm/json_web_key_unittest.cc#oldcode147 media/cdm/json_web_key_unittest.cc:147: ExtractJWKKeysAndExpect("{ \"keys\": [] }", true, 0); On 2014/12/23 00:41:20, ...
6 years ago (2014-12-23 00:54:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798583003/1
6 years ago (2014-12-23 03:33:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/17282)
6 years ago (2014-12-23 04:35:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798583003/20001
6 years ago (2014-12-23 07:25:04 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-23 07:55:35 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-23 07:56:35 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5287c3c5dba8723c07761f291dc7f710c9d98064
Cr-Commit-Position: refs/heads/master@{#309543}

Powered by Google App Engine
This is Rietveld 408576698