Issue 798563005: Simplify the internals of HTMLStyleElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 798563005: Simplify the internals of HTMLStyleElement. (Closed)

Created:
6 years ago by esprehn

Modified:
6 years ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Simplify the internals of HTMLStyleElement. addStyleSheetCandidateNode already checks inDocument(), so we can remove that check. We can also merge processStyleSheet, process and createSheet I also removed the print media query check, and inlined clearDocumentData into the destructor. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/59145288bae55b0fce4276b017df6a1117bcf00f

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -43 lines)			Patch
	M	sky/engine/core/html/HTMLStyleElement.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	sky/engine/core/html/HTMLStyleElement.cpp	View		5 chunks	+19 lines, -39 lines	0 comments	Download

Total messages: 3 (0 generated)

esprehn

6 years ago (2014-12-12 21:14:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
59145288bae55b0fce4276b017df6a1117bcf00f (presubmit successful).