Issue 798553002: [turbofan] Mark arm64 cbz/cbnz tbz/tbnz instructions as branch instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 798553002: [turbofan] Mark arm64 cbz/cbnz tbz/tbnz instructions as branch instructions. (Closed)

Created:
6 years ago by baptiste.afsa1

Modified:
6 years ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Mark arm64 cbz/cbnz tbz/tbnz instructions as branch instructions. The instruction selector now selects pseudo instructions: CompareAndBranch or TestAndBranch which are associated with their continuations so that generic code in the code generator will treat them as branch instruction and will be able to apply optimization like avoiding branches when the code can falltrhough. R=bmeurer@chromium.org

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+127 lines, -109 lines)			Patch
M	src/compiler/arm64/code-generator-arm64.cc	View	3 chunks	+98 lines, -84 lines	0 comments	Download
M	src/compiler/arm64/instruction-codes-arm64.h	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	src/compiler/arm64/instruction-selector-arm64.cc	View	3 chunks	+6 lines, -9 lines	0 comments	Download
M	test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc	View	10 chunks	+20 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

baptiste.afsa1

PTAL It improves performance on asm.js life and skinning benchmarks.

6 years ago (2014-12-11 11:56:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798553002/1

6 years ago (2014-12-11 12:09:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages