Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 798493005: Merge 187458 "Correctly move script element to a detached document." (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
sof
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Project:
blink
Visibility:
Public.

Description

Merge 187458 "Correctly move script element to a detached document." > Correctly move script element to a detached document. > > If a script element ends up being moved over to a new document's tree, > its script loader is re-associated with that document's script runner > if the load is still pending. That association of script runner and > loader needs to reflect document association of the element itself, > otherwise completion of script loading and any later movement of the > element to another document will go wrong. > > R=marja,jochen > BUG=443115 > > Review URL: https://codereview.chromium.org/809323002 TBR=sigbjornf@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, --1 lines) Patch
A + LayoutTests/fast/dom/HTMLScriptElement/resources/script-element-moved-to-detached-document-crash-frames.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLScriptElement/script-element-moved-to-detached-document-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLScriptElement/script-element-moved-to-detached-document-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sof
5 years, 11 months ago (2014-12-30 09:58:21 UTC) #1
sof
5 years, 11 months ago (2014-12-30 09:58:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r187772 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698