tools/telemetry/telemetry/core/platform/cros_platform_backend.py - Issue 798483004: Implement FlushSystemCacheForDirectory for Chrome OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/cros_platform_backend.py

Issue 798483004: Implement FlushSystemCacheForDirectory for Chrome OS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove |ignoring| Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/android_platform_backend.py ('k') | tools/telemetry/telemetry/core/platform/desktop_platform_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/cros_platform_backend.py

diff --git a/tools/telemetry/telemetry/core/platform/cros_platform_backend.py b/tools/telemetry/telemetry/core/platform/cros_platform_backend.py

index e3d41c4ef030f91803995d00e23ee915322aa77a..c15c6f7802a3e1d544e4daac293b8b50b45797c4 100644

--- a/tools/telemetry/telemetry/core/platform/cros_platform_backend.py

+++ b/tools/telemetry/telemetry/core/platform/cros_platform_backend.py

@@ -46,7 +46,10 @@ class CrosPlatformBackend(

raise NotImplementedError()

def RunCommand(self, args):

- return self._cri.RunCmdOnDevice(args)[0]

+ stdout, stderr = self._cri.RunCmdOnDevice(args)

+ if stderr:

+ raise RuntimeError(stderr)

+ return stdout

def GetFileContents(self, filename):

try:

@@ -106,8 +109,11 @@ class CrosPlatformBackend(

def FlushEntireSystemCache(self):

raise NotImplementedError()

- def FlushSystemCacheForDirectory(self, directory, ignoring=None):

- raise NotImplementedError()

+ def FlushSystemCacheForDirectory(self, directory):

+ flush_command = (

+ '/usr/local/telemetry/src/src/out/Release/clear_system_cache')

+ self.RunCommand(['chmod', '+x', flush_command])

+ self.RunCommand([flush_command, '--recurse', directory])

def CanMonitorPower(self):

return self._powermonitor.CanMonitorPower()