Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 798453002: events: x11: Use device path to detect internal keyboards (Closed)

Created:
6 years ago by spang
Modified:
6 years ago
Reviewers:
rsadam, sadrul
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

events: x11: Use device path to detect internal keyboards Use the device's path in the device tree rather than a device name whitelist to determine if it is permanently attached. This is consistent with the strategy we've been using for touchscreens. This slightly changes the code to just remove non-keyboards from the keyboard list, instead of overloading INPUT_DEVICE_UNKNOWN to mean it is not a keyboard. TEST=manual on chromeos build on ubuntu BUG=437539 Committed: https://crrev.com/f9ac82d3db93d4b61ed3436b528681c8a0252caf Cr-Commit-Position: refs/heads/master@{#308178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -25 lines) Patch
M ui/events/platform/x11/x11_hotplug_event_handler.cc View 3 chunks +3 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
spang
depends on https://codereview.chromium.org/791743004/
6 years ago (2014-12-11 02:40:26 UTC) #2
sadrul
lgtm
6 years ago (2014-12-11 15:44:50 UTC) #3
rsadam
lgtm
6 years ago (2014-12-11 16:38:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798453002/1
6 years ago (2014-12-12 18:49:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/17821)
6 years ago (2014-12-12 21:14:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798453002/1
6 years ago (2014-12-12 21:17:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 22:14:19 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-12 22:15:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9ac82d3db93d4b61ed3436b528681c8a0252caf
Cr-Commit-Position: refs/heads/master@{#308178}

Powered by Google App Engine
This is Rietveld 408576698