Issue 798433002: Autofill: Add some helper function to make getting elements by id less tedious.

Issue 798433002: Autofill: Add some helper function to make getting elements by id less tedious. (Closed)

Created:
6 years ago by Lei Zhang

Modified:
6 years ago

Reviewers:
Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Autofill: Add some helper function to make getting elements by id less tedious. Committed: https://crrev.com/1dd04910bd1c312ee0098004647b18c1a3578eee Cr-Commit-Position: refs/heads/master@{#307971}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -120 lines)			Patch
	M	chrome/renderer/autofill/form_autofill_browsertest.cc	View	1	42 chunks	+74 lines, -120 lines	0 comments	Download

Total messages: 9 (2 generated)

Evan Stade

I'm not convinced this is much better (net 11 lines lost), but if you are ...

6 years ago (2014-12-11 01:54:50 UTC) #3

Lei Zhang

On 2014/12/11 01:54:50, Evan Stade wrote: > I'm not convinced this is much better (net ...

6 years ago (2014-12-11 02:34:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798433002/20001

6 years ago (2014-12-11 19:45:30 UTC) #7

commit-bot: I haz the power

6 years ago (2014-12-11 21:02:33 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/1dd04910bd1c312ee0098004647b18c1a3578eee
Cr-Commit-Position: refs/heads/master@{#307971}