Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 798413003: Remove obsolete V8_INFINITY macro. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete V8_INFINITY macro. Use std::numeric_limits consistently. R=svenpanne@chromium.org Committed: https://crrev.com/31c66e2d53569c4e229d55483d28208491e73612 Cr-Commit-Position: refs/heads/master@{#25897}

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 1

Patch Set 3 : Address Svens smiley. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -264 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/assembler.cc View 5 chunks +7 lines, -4 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 8 chunks +21 lines, -12 lines 0 comments Download
M src/conversions-inl.h View 3 chunks +5 lines, -6 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/mips/simulator-mips.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/mips64/simulator-mips64.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/strtod.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M src/types.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M test/cctest/compiler/codegen-tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/function-tester.h View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 1 chunk +6 lines, -17 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-jsops.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-typer.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M test/cctest/compiler/value-helper.h View 2 chunks +12 lines, -11 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 1 5 chunks +94 lines, -89 lines 0 comments Download
M test/cctest/test-checks.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-double.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M test/cctest/test-strtod.cc View 2 chunks +17 lines, -11 lines 0 comments Download
M test/cctest/test-types.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M test/cctest/types-fuzz.h View 2 chunks +8 lines, -4 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 2 chunks +20 lines, -20 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 2 chunks +21 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Benedikt Meurer
6 years ago (2014-12-19 06:01:32 UTC) #1
Benedikt Meurer
PTAL
6 years ago (2014-12-19 06:02:04 UTC) #2
Sven Panne
lgtm https://codereview.chromium.org/798413003/diff/20001/src/arm64/simulator-arm64.cc File src/arm64/simulator-arm64.cc (right): https://codereview.chromium.org/798413003/diff/20001/src/arm64/simulator-arm64.cc#newcode2508 src/arm64/simulator-arm64.cc:2508: // example, a double with exponent 127 (std::numeric_limits<float>::max()_EXP) ...
6 years ago (2014-12-19 06:50:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798413003/40001
6 years ago (2014-12-19 06:51:06 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-19 07:17:55 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/31c66e2d53569c4e229d55483d28208491e73612 Cr-Commit-Position: refs/heads/master@{#25897}
6 years ago (2014-12-19 07:18:11 UTC) #7
Michael Achenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/813813003/ by machenbach@chromium.org. ...
6 years ago (2014-12-20 13:11:34 UTC) #8
Michael Achenbach
6 years ago (2014-12-20 16:13:33 UTC) #9
Message was sent while issue was closed. 
On 2014/12/20 13:11:34, Michael Achenbach wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/813813003/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: Speculative revert. This seems to block the
current
> roll: https://codereview.chromium.org/819653003/
> 
> I retried several times, also with a new roll. The error is internal - but
that
> doesn't make much of a difference..

After reverting this, the roll got through again:
https://codereview.chromium.org/795253005/

Powered by Google App Engine
This is Rietveld 408576698