Add more filetypes to DM's image tests.

dm/DM.cpp

 // Main binary for DM.
 // For a high-level overview, please see dm/README.
 
 #include "CrashHandler.h"
 #include "LazyDecodeBitmap.h"
 #include "SkCommonFlags.h"
 #include "SkForceLinking.h"
 #include "SkGraphics.h"
 #include "SkOSFile.h"
 #include "SkPicture.h"
@@ skipping 231 matching lines @@
 
 
     SkTArray<SkString> skps;
     if (!FLAGS_skps.isEmpty()) {
         const char* suffixes[] = { "skp" };
         find_files(FLAGS_skps[0], suffixes, SK_ARRAY_COUNT(suffixes), &skps);
     }
 
     SkTArray<SkString> images;
     if (!FLAGS_images.isEmpty()) {
-        const char* suffixes[] = { "bmp", "gif", "jpg", "png", "webp", "ktx", "astc" };
-        find_files(FLAGS_images[0], suffixes, SK_ARRAY_COUNT(suffixes), &images);
+        const char* suffixes[] = { "bmp", "gif", "jpg", "jpeg", "png", "webp",

[mtklein, 2014/12/15 16:06:32]

Why don't we just write
  const char* suffixes[] = {
    "bmp", "gif", "jpg", "jpeg", "png", "webp", "ktx", "astc", "wbmp", "ico",
    "BMP", "GIF", "JPG", "JPEG", "PNG", "WEBP", "KTX", "ASTC", "WBMP", "ICO",
  };
and call find_files() once?

[scroggo, 2014/12/15 16:16:00]

We could do that. (We did it in skimage.) The advantage to this approach is that
we reduce the chance of copy/forget error for the capitalized versions.

+                                   "ktx", "astc", "wbmp", "ico" };
+        const size_t count = SK_ARRAY_COUNT(suffixes);
+        find_files(FLAGS_images[0], suffixes, count, &images);
+        // Also check for the capitalized versions.
+        // Note: capSuffixes does not grow or shrink, so we can continue to use
+        // "count".
+        SkTArray<const char*> capSuffixes(suffixes, count);
+        for (size_t i = 0; i < count; ++i) {
+            char* cap = SkStrDup(capSuffixes[i]);
+            for (size_t j = 0; j < strlen(cap); ++j) {
+                cap[j] = toupper(cap[j]);
+            }
+            capSuffixes[i] = cap;
+        }
+        find_files(FLAGS_images[0], capSuffixes.begin(), count, &images);
+        for (size_t i = 0; i < count; ++i) {
+            sk_free(const_cast<char*>(capSuffixes[i]));
+        }
     }
 
     SkDebugf("%d GMs x %d configs, %d tests, %d pictures, %d images\n",
              gms.count(), configs.count(), tests.count(), skps.count(), images.count());
     DM::Reporter reporter;
 
     DM::TaskRunner tasks;
     kick_off_tests(tests, &reporter, &tasks);
     kick_off_gms(gms, configs, gpuAPI, &reporter, &tasks);
     kick_off_skps(skps, &reporter, &tasks);
@@ skipping 14 matching lines @@
     report_failures(failures);
     return failures.count() > 0;
 }
 
 #if !defined(SK_BUILD_FOR_IOS) && !defined(SK_BUILD_FOR_NACL)
 int main(int argc, char** argv) {
     SkCommandLineFlags::Parse(argc, argv);
     return dm_main();
 }
 #endif