Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 798363007: [turbofan] use START and END gap positions for constraints (Closed)

Created:
6 years ago by dcarney
Modified:
6 years ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] use START and END gap positions for constraints R=bmeurer@chromium.org Committed: https://crrev.com/84345afbfb25c013e6d503827d8a4f6f075c929b Cr-Commit-Position: refs/heads/master@{#25864}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -67 lines) Patch
M src/compiler/register-allocator.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 5 6 9 chunks +57 lines, -65 lines 0 comments Download
M test/unittests/compiler/register-allocator-unittest.cc View 1 2 3 4 5 6 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
LGTM with nit https://codereview.chromium.org/798363007/diff/100001/src/compiler/register-allocator.cc File src/compiler/register-allocator.cc (right): https://codereview.chromium.org/798363007/diff/100001/src/compiler/register-allocator.cc#newcode1240 src/compiler/register-allocator.cc:1240: GapInstruction::InnerPosition positions[] = {GapInstruction::END, Nit: rename ...
6 years ago (2014-12-17 11:36:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798363007/120001
6 years ago (2014-12-17 11:46:52 UTC) #4
commit-bot: I haz the power
Committed patchset #7 (id:120001)
6 years ago (2014-12-17 12:13:56 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-17 12:14:11 UTC) #6
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/84345afbfb25c013e6d503827d8a4f6f075c929b
Cr-Commit-Position: refs/heads/master@{#25864}

Powered by Google App Engine
This is Rietveld 408576698