Issue 798323005: [Extensions Toolbar] Fix an issue where incognito extensions were overflowed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 798323005: [Extensions Toolbar] Fix an issue where incognito extensions were overflowed (Closed)

Created:
6 years ago by Devlin

Modified:
6 years ago

Reviewers:
Finnur

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Extensions Toolbar] Fix an issue where incognito extensions were overflowed The ToolbarActionsBar wouldn't resize properly in the case of an incognito extension being added. BUG=443564 Committed: https://crrev.com/f28703ba57c37a5a39e13014209f4d22b4f87521 Cr-Commit-Position: refs/heads/master@{#309456}

Patch Set 1 #

Patch Set 2 : Latest master #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -15 lines)			Patch
	M	chrome/browser/extensions/extension_toolbar_model.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	chrome/browser/ui/toolbar/toolbar_actions_bar.cc	View	1	3 chunks	+16 lines, -12 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798323005/20001

6 years ago (2014-12-22 19:07:37 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-22 20:33:25 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/f28703ba57c37a5a39e13014209f4d22b4f87521
Cr-Commit-Position: refs/heads/master@{#309456}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages