Issue 798323004: Make ServiceWorkerClient.focus() bound to ServiceWorkerClientAttributes flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 798323004: Make ServiceWorkerClient.focus() bound to ServiceWorkerClientAttributes flag. (Closed)

Created:
6 years ago by mlamouri (slow - plz ping)

Modified:
6 years ago

Reviewers:
Mike West

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Make ServiceWorkerClient.focus() bound to ServiceWorkerClientAttributes flag. We will need to enable all the new attributes at the same time so it would be better to have them under the same flag. We might also enable .focus() before Push, for Notifications. BUG=431160, 437149 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187159

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/modules/serviceworkers/ServiceWorkerClient.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798323004/1

6 years ago (2014-12-15 15:24:45 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-15 18:01:48 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187159

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages