Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(119)

Issue 7983013: Merge 95259 - Fragment navigations should interrupt a provisional load of a different document (Closed)

Created:
7 years, 9 months ago by Mihai Parparita -not on Chrome
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 95259 - Fragment navigations should interrupt a provisional load of a different document https://bugs.webkit.org/show_bug.cgi?id=64556 Source/WebCore: Reviewed by Adam Barth. Tests: http/tests/history/back-with-fragment-change.php http/tests/navigation/navigation-interrupted-by-fragment.html * loader/FrameLoader.cpp: Stop provisional load if a fragment commits. * loader/HistoryController.cpp: Don't commit the wrong provisional item. LayoutTests: Reviewed by Adam Barth. Required page-dismissal-modal-dialogs-iframe.html to be updated since the dummy <a href="#"> link was clicked after the provisional load was kicked off, thus causing it to to be aborted. * fast/loader/page-dismissal-modal-dialogs.html: * fast/loader/resources/page-dismissal-modal-dialogs-iframe.html: * http/tests/history/back-with-fragment-change-expected.txt: Added. * http/tests/history/back-with-fragment-change.php: Added. * http/tests/history/resources/back-with-fragment-change-target.html: Added. * http/tests/navigation/navigation-interrupted-by-fragment-expected.txt: Added. * http/tests/navigation/navigation-interrupted-by-fragment.html: Added. TBR=mihaip@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95561

Patch Set 1 #

Messages

Total messages: 1 (0 generated)
Mihai Parparita -not on Chrome
7 years, 9 months ago (2011-09-20 19:04:06 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698