Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 798283002: Cleanup: Move PaintVerticalDivider() into bookmark_bar_view.cc. (Closed)

Created:
6 years ago by tfarina
Modified:
6 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Move PaintVerticalDivider() into bookmark_bar_view.cc. Actually it does not have to do much with DetachableToolbarView. It is used by BookmarkBarView to draw a button separator in the left side of "Other bookmarks" folder. The "Other bookmarks" only appears when you actually have bookmarks on it. So to separate it from the rest of the Bookmarks bar nodes, a separator is drawn. Screenshot: http://imgur.com/nW38lEy BUG=None TEST=open chrome, bookmark something in the "Other bookmarks" folder, make sure you have "Bookmarks bar" shown, then make sure the separator is there. No regressions observed. R=sky@chromium.org Committed: https://crrev.com/39f40c222c49aab7b49c97c14eec019cd1d4ac49 Cr-Commit-Position: refs/heads/master@{#308371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -50 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +38 lines, -1 line 0 comments Download
M chrome/browser/ui/views/detachable_toolbar_view.h View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/detachable_toolbar_view.cc View 2 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
PTAL
6 years ago (2014-12-14 17:33:07 UTC) #1
sky
LGTM
6 years ago (2014-12-15 17:00:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798283002/1
6 years ago (2014-12-15 17:10:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 18:05:56 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-15 18:06:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39f40c222c49aab7b49c97c14eec019cd1d4ac49
Cr-Commit-Position: refs/heads/master@{#308371}

Powered by Google App Engine
This is Rietveld 408576698