Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 798243004: ES6 computed property names (Closed)

Created:
4 years, 9 months ago by arv (Not doing code reviews)
Modified:
4 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ES6 computed property names This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. This is a revert of the revert, 7d48fd9dc29c8f5d7c8b5215f9bd537cdd005eba. BUG=v8:3754 LOG=Y R=dslomov@chromium.org Committed: https://crrev.com/74e38e34b3caecfb660c3ed1336a58c551215793 Cr-Commit-Position: refs/heads/master@{#26084}

Patch Set 1 #

Patch Set 2 : Move back the bailout into the loop #

Patch Set 3 : Disable test on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1370 lines, -205 lines) Patch
M src/arm/full-codegen-arm.cc View 5 chunks +69 lines, -8 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 5 chunks +69 lines, -8 lines 0 comments Download
M src/ast.h View 3 chunks +21 lines, -17 lines 0 comments Download
M src/ast.cc View 6 chunks +33 lines, -17 lines 0 comments Download
M src/ast-numbering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +28 lines, -27 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +10 lines, -9 lines 0 comments Download
M src/full-codegen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +67 lines, -8 lines 0 comments Download
M src/parser.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/parser.cc View 5 chunks +12 lines, -7 lines 0 comments Download
M src/preparser.h View 1 17 chunks +103 lines, -37 lines 0 comments Download
M src/preparser.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/runtime.js View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-classes.cc View 2 chunks +1 line, -45 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M src/typing.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +67 lines, -8 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +62 lines, -1 line 0 comments Download
A test/mjsunit/harmony/computed-property-names.js View 1 chunk +270 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/computed-property-names-classes.js View 1 chunk +367 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/computed-property-names-object-literals-methods.js View 1 chunk +121 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
arv (Not doing code reviews)
Move back the bailout into the loop
4 years, 9 months ago (2015-01-15 17:31:29 UTC) #1
arv (Not doing code reviews)
Disable test on windows
4 years, 9 months ago (2015-01-15 17:35:19 UTC) #2
arv (Not doing code reviews)
PTAL Patchset 0 is a straight revert of the revert.
4 years, 9 months ago (2015-01-15 17:37:15 UTC) #3
Dmitry Lomov (no reviews)
lgtm (rubberstamped)
4 years, 9 months ago (2015-01-15 19:03:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798243004/40001
4 years, 9 months ago (2015-01-15 19:35:56 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2015-01-15 20:02:30 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2015-01-15 20:02:48 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/74e38e34b3caecfb660c3ed1336a58c551215793
Cr-Commit-Position: refs/heads/master@{#26084}

Powered by Google App Engine
This is Rietveld 408576698