Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 798173002: Add support for internal overrides for Mac (Closed)

Created:
6 years ago by dcaiafa
Modified:
6 years ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for internal overrides for Mac BUG=302704 Committed: https://crrev.com/f2891d456f55baf973057feac88ca02e97a2e16d Cr-Commit-Position: refs/heads/master@{#308246}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M remoting/host/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/remoting_host.gypi View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dcaiafa
6 years ago (2014-12-13 02:03:42 UTC) #2
Jamie
LGTM with nits. https://codereview.chromium.org/798173002/diff/1/remoting/DEPS File remoting/DEPS (right): https://codereview.chromium.org/798173002/diff/1/remoting/DEPS#newcode15 remoting/DEPS:15: "+remoting/tools", This should be in host/DEPS. ...
6 years ago (2014-12-13 02:12:16 UTC) #3
dcaiafa
ptal https://codereview.chromium.org/798173002/diff/1/remoting/DEPS File remoting/DEPS (right): https://codereview.chromium.org/798173002/diff/1/remoting/DEPS#newcode15 remoting/DEPS:15: "+remoting/tools", On 2014/12/13 02:12:16, Jamie wrote: > This ...
6 years ago (2014-12-13 02:16:56 UTC) #4
Jamie
lgtm
6 years ago (2014-12-13 02:21:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798173002/20001
6 years ago (2014-12-13 02:22:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-13 03:58:35 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-13 03:59:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f2891d456f55baf973057feac88ca02e97a2e16d
Cr-Commit-Position: refs/heads/master@{#308246}

Powered by Google App Engine
This is Rietveld 408576698