Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 798103002: Possible fix for ExtensionFunctionDispatcher::DispatchWithCallbackInternal. (Closed)

Created:
6 years ago by Reilly Grant (use Gerrit)
Modified:
6 years ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Possible fix for ExtensionFunctionDispatcher::DispatchWithCallbackInternal. This is a possible fix for crashes observed in this function. The member variable browser_context_ is possibly invalid because the object may be freed by function->Run(). To avoid this we move the call to ProcessManager::Get() to before where function->Run() is called. BUG=441679 Committed: https://crrev.com/accea33ab9847b38b96bfe50c85b27148e76cde1 Cr-Commit-Position: refs/heads/master@{#308214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M extensions/browser/extension_function_dispatcher.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Yoyo, please take a look at this minor change.
6 years ago (2014-12-12 21:52:05 UTC) #2
Yoyo Zhou
LGTM
6 years ago (2014-12-13 00:44:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798103002/1
6 years ago (2014-12-13 00:50:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-13 01:30:18 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-13 01:31:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/accea33ab9847b38b96bfe50c85b27148e76cde1
Cr-Commit-Position: refs/heads/master@{#308214}

Powered by Google App Engine
This is Rietveld 408576698