Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9273)

Unified Diff: chrome_frame/test/net/fake_external_tab.cc

Issue 7981011: Fix the ChromeFrame net tests dchecks in debug builds due to a missing AtExitManager instance. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/net/fake_external_tab.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/net/fake_external_tab.cc
===================================================================
--- chrome_frame/test/net/fake_external_tab.cc (revision 101850)
+++ chrome_frame/test/net/fake_external_tab.cc (working copy)
@@ -231,6 +231,9 @@
void FakeExternalTab::Initialize() {
DCHECK(g_browser_process == NULL);
+
+ notificaton_service_.reset(new NotificationService);
+
base::SystemMonitor system_monitor;
icu_util::Initialize();
@@ -560,8 +563,6 @@
google_breakpad::scoped_ptr<google_breakpad::ExceptionHandler> breakpad(
InitializeCrashReporting(HEADLESS));
- NotificationService service;
-
// TODO(tommi): Stuff be broke. Needs a fixin'.
// This is awkward: the TestSuite derived CFUrlRequestUnittestRunner contains
// the instance of the AtExitManager that RegisterPathProvider() and others
« no previous file with comments | « chrome_frame/test/net/fake_external_tab.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698