Issue 7981011: Fix the ChromeFrame net tests dchecks in debug builds due to a missing AtExitManager instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7981011: Fix the ChromeFrame net tests dchecks in debug builds due to a missing AtExitManager instance. (Closed)

Created:
9 years, 3 months ago by ananta

Modified:
9 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix the ChromeFrame net tests dchecks in debug builds due to a missing AtExitManager instance. The AtExitManager instance is initialized by the NetTestSuite class constructor. The dchecks fire because the NotificationService constructor uses the lazy instance class which relies on the AtExitManager instance being initialized. The fix is to initialize the NotificationService instance after the NetTestSuite constructor has done its job. BUG=none TEST=chrome frame net tests should pass in debug builds. TBR=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101994

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome_frame/test/net/fake_external_tab.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	chrome_frame/test/net/fake_external_tab.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages