Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1495)

Unified Diff: chrome/browser/renderer_host/accelerated_surface_container_touch.h

Issue 7980006: Implement OSMesa image transport for TOUCH_UI builds (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix mac build Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/accelerated_surface_container_touch.h
diff --git a/chrome/browser/renderer_host/accelerated_surface_container_touch.h b/chrome/browser/renderer_host/accelerated_surface_container_touch.h
index 4303cd87a44d835d1b47f1b652613e0f977827c9..2af2cbbeb0d27410f1b57a9be1adfa56914c8f7a 100644
--- a/chrome/browser/renderer_host/accelerated_surface_container_touch.h
+++ b/chrome/browser/renderer_host/accelerated_surface_container_touch.h
@@ -8,6 +8,7 @@
#include "base/basictypes.h"
#include "ui/gfx/compositor/compositor_gl.h"
+#include "ui/gfx/surface/transport_dib.h"
// Helper class for storing image data from the GPU process renderered
// on behalf of the RWHVV. It assumes that GL context that will display
@@ -16,14 +17,22 @@
class AcceleratedSurfaceContainerTouch : public ui::TextureGL {
public:
static AcceleratedSurfaceContainerTouch* CreateAcceleratedSurfaceContainer(
- const gfx::Size& size,
- uint64 surface_handle);
+ const gfx::Size& size);
// TextureGL implementation
virtual void SetCanvas(const SkCanvas& canvas,
const gfx::Point& origin,
const gfx::Size& overall_size) OVERRIDE;
+ // Initialize the surface container, and returns an ID for it.
+ // The |surface_id| given to this function may be modified, and the returned
sky 2011/09/21 21:39:55 This sentence looks wrong. The return value is a b
+ // value should be used to identify the object.
+ virtual bool Initialize(uint64 *surface_id) = 0;
sky 2011/09/21 21:39:55 'uint64 *surface_id' -> 'uint64* surface_id'
+
+ // Some implementations of this class use shared memory, this the handle
sky 2011/09/21 21:39:55 'this the' -> 'this is the' ?
+ // to the shared buffer, which is part of the surface container.
+ virtual TransportDIB::Handle handle() const;
sky 2011/09/21 21:39:55 Don't use unix_hacker_style for virtual methods.
+
protected:
explicit AcceleratedSurfaceContainerTouch(const gfx::Size& size);

Powered by Google App Engine
This is Rietveld 408576698