Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/renderer/content_settings_observer.h

Issue 797993002: Remove kInstantProcess from renderer ContentSettingsObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/content_settings_observer.h
diff --git a/chrome/renderer/content_settings_observer.h b/chrome/renderer/content_settings_observer.h
index b6f13b653fbbb3ef892b379b934d4710523e6c6b..c244c9babdd6cb556c32c48f3b7d5b5370a09b50 100644
--- a/chrome/renderer/content_settings_observer.h
+++ b/chrome/renderer/content_settings_observer.h
@@ -34,7 +34,8 @@ class ContentSettingsObserver
public blink::WebPermissionClient {
public:
ContentSettingsObserver(content::RenderFrame* render_frame,
jochen (gone - plz use gerrit) 2014/12/12 14:58:20 please add a comment what should_whitelist means
- extensions::Dispatcher* extension_dispatcher);
+ extensions::Dispatcher* extension_dispatcher,
+ bool should_whitelist);
~ContentSettingsObserver() override;
// Sets the content setting rules which back |AllowImage()|, |AllowScript()|,
@@ -119,8 +120,9 @@ class ContentSettingsObserver
#endif
// Helpers.
- // True if |frame| contains content that is white-listed for content settings.
- static bool IsWhitelistedForContentSettings(content::RenderFrame* frame);
+ // True if |render_frame()| contains content that is white-listed for content
+ // settings.
+ bool IsWhitelistedForContentSettings() const;
static bool IsWhitelistedForContentSettings(
const blink::WebSecurityOrigin& origin,
const GURL& document_url);
@@ -158,6 +160,9 @@ class ContentSettingsObserver
typedef std::map<int, blink::WebPermissionCallbacks> PermissionRequestMap;
PermissionRequestMap permission_requests_;
+ // If true, IsWhitelistedForContentSettings will always return true.
+ const bool should_whitelist_;
+
DISALLOW_COPY_AND_ASSIGN(ContentSettingsObserver);
};

Powered by Google App Engine
This is Rietveld 408576698