Remove kInstantProcess from renderer ContentSettingsObserver

Remove kInstantProcess from renderer ContentSettingsObserver

The kInstantProcess flag was used to check if the current frame belongs to instant and should be whitelisted. This would cause layering troubles once ContentSettingsObserver is componentised.

Instead, this CL moves the check back to the construction of the observer, in ChromeContentRendererClient, and only records the Boolean flag for whitelisting in the observer.

BUG=384874
Committed: https://crrev.com/f0e8e830f238eefdf702a481308ce9661cda7b75
Cr-Commit-Position: refs/heads/master@{#308106}

[vabr (Chromium), 2014-12-12 14:55:46]

vabr@chromium.org changed reviewers:
+ jochen@chromium.org

[vabr (Chromium), 2014-12-12 14:55:47]

Hi Jochen,

This implements your recommendation. PTAL!

Vaclav

[jochen (gone - plz use gerrit), 2014-12-12 14:58:20]

lgtm with a less generic name than should_whitelist

https://codereview.chromium.org/797993002/diff/1/chrome/renderer/chrome_conte...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/797993002/diff/1/chrome/renderer/chrome_conte...
chrome/renderer/chrome_content_renderer_client.cc:447: bool should_whitelist =
nit. should_whitelist_for_content_settings

https://codereview.chromium.org/797993002/diff/1/chrome/renderer/content_sett...
File chrome/renderer/content_settings_observer.h (right):

https://codereview.chromium.org/797993002/diff/1/chrome/renderer/content_sett...
chrome/renderer/content_settings_observer.h:36:
ContentSettingsObserver(content::RenderFrame* render_frame,
please add a comment what should_whitelist means

[vabr (Chromium), 2014-12-12 16:02:40]

Thanks, Jochen!

Comments addressed, I'll send this to the CQ soon.

Vaclav

[vabr (Chromium), 2014-12-12 16:04:14]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2014-12-12 16:04:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/797993002/20001

[commit-bot: I haz the power, 2014-12-12 17:10:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-12 17:11:23]

Patchset 2 (id:??) landed as
https://crrev.com/f0e8e830f238eefdf702a481308ce9661cda7b75
Cr-Commit-Position: refs/heads/master@{#308106}