Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 797963002: pass dst-rect through from drawBitmapRect for better precision (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

pass dst-rect through from drawBitmapRect for better precision BUG=skia: Committed: https://skia.googlesource.com/skia/+/0393912de72bc3d8b3640c122c53470dd0da1e6d

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -22 lines) Patch
M gm/bitmaprect.cpp View 2 chunks +1 line, -1 line 0 comments Download
M include/core/SkDraw.h View 2 chunks +8 lines, -2 lines 0 comments Download
M include/core/SkRect.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkDraw.cpp View 1 5 chunks +36 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
ptal
6 years ago (2014-12-15 20:43:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797963002/40001
6 years ago (2014-12-15 20:44:31 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-15 20:44:32 UTC) #5
robertphillips
lgtm
6 years ago (2014-12-15 21:41:26 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 21:42:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0393912de72bc3d8b3640c122c53470dd0da1e6d

Powered by Google App Engine
This is Rietveld 408576698