src/compiler/pipeline.cc - Issue 797943002: Consistently use only one of virtual/OVERRIDE/FINAL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/pipeline.cc

Issue 797943002: Consistently use only one of virtual/OVERRIDE/FINAL. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Removed temporary hack. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/pipeline.cc

diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc

index 5515babdcaa5465c22cdb80ebe0bec31c3a63575..2407d0d9ce08a9d8856b25ee237cfa55f261c187 100644

--- a/src/compiler/pipeline.cc

+++ b/src/compiler/pipeline.cc

@@ -302,7 +302,7 @@ class AstGraphBuilderWithPositions : public AstGraphBuilder {

}

#define DEF_VISIT(type) \

- virtual void Visit##type(type* node) OVERRIDE { \

+ void Visit##type(type* node) OVERRIDE { \

SourcePositionTable::Scope pos(source_positions_, \

SourcePosition(node->position())); \

AstGraphBuilder::Visit##type(node); \

« no previous file with comments | « src/compiler/operator.h ('k') | src/compiler/simplified-operator-reducer.h » ('j') | no next file with comments »