Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: src/compiler/operator.h

Issue 797943002: Consistently use only one of virtual/OVERRIDE/FINAL. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed temporary hack. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/machine-operator-reducer.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/operator.h
diff --git a/src/compiler/operator.h b/src/compiler/operator.h
index 810851b626a02e0a9a3e5510d716bfff3a5f11cc..d6f80ad1cf7e34affd8bc97b5ea82b2ffb220923 100644
--- a/src/compiler/operator.h
+++ b/src/compiler/operator.h
@@ -141,12 +141,12 @@ class Operator1 : public Operator {
T const& parameter() const { return parameter_; }
- virtual bool Equals(const Operator* other) const FINAL {
+ bool Equals(const Operator* other) const FINAL {
if (opcode() != other->opcode()) return false;
const Operator1<T>* that = static_cast<const Operator1<T>*>(other);
return this->pred_(this->parameter(), that->parameter());
}
- virtual size_t HashCode() const FINAL {
+ size_t HashCode() const FINAL {
return base::hash_combine(this->opcode(), this->hash_(this->parameter()));
}
virtual void PrintParameter(std::ostream& os) const {
@@ -154,7 +154,7 @@ class Operator1 : public Operator {
}
protected:
- virtual void PrintTo(std::ostream& os) const FINAL {
+ void PrintTo(std::ostream& os) const FINAL {
os << mnemonic();
PrintParameter(os);
}
« no previous file with comments | « src/compiler/machine-operator-reducer.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698