Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: src/ast-value-factory.h

Issue 797943002: Consistently use only one of virtual/OVERRIDE/FINAL. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed temporary hack. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast-this-access-visitor.h ('k') | src/ast-value-factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast-value-factory.h
diff --git a/src/ast-value-factory.h b/src/ast-value-factory.h
index 7b82e4a13e4080a73dc01036181153f9e5599f55..a189f173b56fa2e2bf0b0a412e301441e1348721 100644
--- a/src/ast-value-factory.h
+++ b/src/ast-value-factory.h
@@ -64,13 +64,13 @@ class AstString : public ZoneObject {
class AstRawString : public AstString {
public:
- virtual int length() const OVERRIDE {
+ int length() const OVERRIDE {
if (is_one_byte_)
return literal_bytes_.length();
return literal_bytes_.length() / 2;
}
- virtual void Internalize(Isolate* isolate) OVERRIDE;
+ void Internalize(Isolate* isolate) OVERRIDE;
bool AsArrayIndex(uint32_t* index) const;
@@ -124,11 +124,9 @@ class AstConsString : public AstString {
: left_(left),
right_(right) {}
- virtual int length() const OVERRIDE {
- return left_->length() + right_->length();
- }
+ int length() const OVERRIDE { return left_->length() + right_->length(); }
- virtual void Internalize(Isolate* isolate) OVERRIDE;
+ void Internalize(Isolate* isolate) OVERRIDE;
private:
friend class AstValueFactory;
« no previous file with comments | « src/ast-this-access-visitor.h ('k') | src/ast-value-factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698